Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_commandline.py@360 PS5, Line 360: if vector.get_value('strict_hs2_protocol'): > I'm not sure what you're looking for here... I was thinking something like skip_if_strict_hs2() and not duplicate the strings but OK to leave as-is if you prefer. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py@352 PS5, Line 352: pytest.skip("Failed, need to investigate.") > Makes sense, but should I just make one umbrella Jira for all the TODOs? O Umbrella JIRA Is fine as long as the issues are enumerated. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py@1092 PS5, Line 1092: pytest.skip("The now() function is not supported by hive frontend.") > Heh, yeah, this is more of a frontend issue string can say that test is Impala-specific. -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 23 Jul 2021 16:54:39 +0000 Gerrit-HasComments: Yes
