Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/17660/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/17660/4/shell/impala_shell.py@193 PS4, Line 193: s flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_commandline.py@141 PS4, Line 141: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_commandline.py@141 PS4, Line 141: v.get_value('protocol') != 'beeswax' or line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_commandline.py@142 PS4, Line 142: n flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_interactive.py@172 PS4, Line 172: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_interactive.py@172 PS4, Line 172: v.get_value('protocol') != 'beeswax' or line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17660/4/tests/shell/test_shell_interactive.py@173 PS4, Line 173: n flake8: E126 continuation line over-indented for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 20 Jul 2021 21:01:04 +0000 Gerrit-HasComments: Yes
