Hello Vihang Karajgaonkar, [email protected], Yu-Wen Lai, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17713
to look at the new patch set (#4).
Change subject: IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor
and Catalog metastore server
......................................................................
IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and
Catalog metastore server
Currently, when doing create/drop table/db from catalogD,
catalogOpExecutor (via Impala Shell) and metastore server (via HS2)
acquires lock on their own lock objects to prevent concurrent
create/drop operations in HMS. But that does not prevent these
concurrent operations across CatalogOpExecutor and Metastore server.
For example currently a user can perform create/drop HMS operation
from Impala shell and catalog metastore server concurrently which is
not the desired behavior.
This patch unifies the lock object which will be acquired by both
catalogOpExecutor as well as metastore server.
Testing:
Relying on existing tests since it is a small refactoring.
Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001
---
M
fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
2 files changed, 202 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/17713/4
--
To view, visit http://gerrit.cloudera.org:8080/17713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001
Gerrit-Change-Number: 17713
Gerrit-PatchSet: 4
Gerrit-Owner: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>