Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17713 )
Change subject: IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and Catalog metastore server ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG@23 PS4, Line 23: Relying on existing tests since it is a small refactoring > I don't think there are any existing tests which exercise these DDLs concur @Vihang @Kishen: I thought about some create/drop table/db scenarios that are supposed to work after acquiring lock and fail without it. But I couldn't find such scenarios. However I can write a test to ensure that lock is shared b/w catalogOpExecutor and MetastoreServiceHandler. Basically inject a lock object in CatalogOpExecutor via test and use that lock object to count the number of times lock and unlock was called from all threads that call create/drop table/db apis from both catalogOpExecutor and Metastoreservicehandler. Let me know if it works. -- To view, visit http://gerrit.cloudera.org:8080/17713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001 Gerrit-Change-Number: 17713 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Thu, 29 Jul 2021 18:29:56 +0000 Gerrit-HasComments: Yes
