Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17713 )
Change subject: IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and Catalog metastore server ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG@23 PS4, Line 23: Relying on existing tests since it is a small refactoring > @Vihang @Kishen: I thought about some create/drop table/db scenarios that a yeah, It looks like it not very easy to write a test which would fail before this patch because of the transactional nature of the HMS create/drop APIs and the fact that catalogd first does HMS operations and then the catalogd operations. However, just knowing the fact that it works v/s having a test which executes these paths in parallel and making sure that there are no errors are 2 different things. The test doesn't necessarily need to fail before this patch and work after this patch. Since we may need some more thought on this I am okay creating a follow-up JIRA for this and commit it separately. -- To view, visit http://gerrit.cloudera.org:8080/17713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001 Gerrit-Change-Number: 17713 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Mon, 02 Aug 2021 19:31:27 +0000 Gerrit-HasComments: Yes
