Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/benchmarks/hash-table-benchmark.cc File be/src/benchmarks/hash-table-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/17592/5/be/src/benchmarks/hash-table-benchmark.cc@332 PS5, Line 332: vector<int> num_tuples { 65536, 262144 }; > Sure, that makes a lot of sense. I was planning to do single node check wit I have benchmarked it on Billion rows table and TPCH-42 just on single node. Results are under sheets 'Billion-Row' and 'TPCH-42' here: https://docs.google.com/spreadsheets/d/1nPkfFG1DDossI8Q-F9ALzc2qJvDAQaHT1yaJzkOQZBs/edit#gid=1839253325. Perf looks almost same - Probe seems a little bit faster with change (2-3% faster on non-skewed data). Reduction of 17% PeakMemory usage seen in Grouping aggregate operator and 21% reduction in Cumulative allocation when running Build benchmark. -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 9 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Aug 2021 21:54:58 +0000 Gerrit-HasComments: Yes
