Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 9: (7 comments) This is really great work! I only found a few more nits. http://gerrit.cloudera.org:8080/#/c/17592/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17592/9//COMMIT_MSG@53 PS9, Line 53: sperately separately http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@661 PS9, Line 661: ~TaggedDuplicateNode() {} nit: this definition is not needed http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@689 PS9, Line 689: it's nit: its http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@692 PS9, Line 692: (Tag bit 0) seems like it's not true anymore http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@698 PS9, Line 698: Tag bit 2 Tag bit 1? http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@723 PS9, Line 723: ~TaggedBucketData() {} nit: this definition is not needed. http://gerrit.cloudera.org:8080/#/c/17592/9/be/src/exec/hash-table.h@732 PS9, Line 732: /// 2. Bucket is attributted as packed with alignment of 4 to ensure no padding : /// is used. Seems like it's not true anymore -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 9 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 16:07:05 +0000 Gerrit-HasComments: Yes
