Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 9: (2 comments) Benchmark Update: SingleNode benchmarks done: 1. MicroBenchmark 2. Billion Rows Probe (join) and Build (groupby) Benchmark 3. TPCH-42 scale: 3 queries including groupby on lineitem (build benchmark). https://docs.google.com/spreadsheets/d/1nPkfFG1DDossI8Q-F9ALzc2qJvDAQaHT1yaJzkOQZBs/edit#gid=0 TPCDS-3000 has been run once and few queries in that are being rerun. http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17592/5//COMMIT_MSG@73 PS5, Line 73: This would help measuring the impact of changes to the HashTable's : data structure and algorithm. > It would be nice to some results in the commit message Added results for microbenchmark, billion Row benchmark and TPCH-42 benchmark. TPCDS-3000 needs few queries to be rerun. http://gerrit.cloudera.org:8080/#/c/17592/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17592/7//COMMIT_MSG@69 PS7, Line 69: As a part of this patch a new Micro Benchmark for HashTable has : been introduced, which will help in measuring these: : 1. Runtime for Building Hash Table and Probing the table. : 2. Memory consumed after building the Table. : This would help measuring the impact of changes to the HashTable's : data structure and algorithm. > nit. Nice addition! May be useful to include some results here. Done. -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 9 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Aug 2021 22:01:47 +0000 Gerrit-HasComments: Yes
