Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 )
Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans ...................................................................... Patch Set 25: (1 comment) Zoltan: Completed the rework for all 8/6/2021 comments. Please let me know if you are able to see the replies. http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/util/min-max-filter-ir.cc File be/src/util/min-max-filter-ir.cc: http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/util/min-max-filter-ir.cc@115 PS20, Line 115: if (UNLIKELY(always_false_)) { > Maybe we could use TruncateUp/TruncateDown: Implement the logic for string. Turns out it is a little bit complicated to deal with +1 and -1 logic. Please review. -- To view, visit http://gerrit.cloudera.org:8080/17706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c2bb5baad622051d1002c9c162c672d428e5446 Gerrit-Change-Number: 17706 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 23:59:02 +0000 Gerrit-HasComments: Yes
