Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 )
Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans ...................................................................... Patch Set 27: (1 comment) http://gerrit.cloudera.org:8080/#/c/17706/25/be/src/exec/nested-loop-join-builder.cc File be/src/exec/nested-loop-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/17706/25/be/src/exec/nested-loop-join-builder.cc@191 PS25, Line 191: return Status::OK(); > I'll file a JIRA for future investigation on the subject. Did some research and found that a non-embedded sink is allocated one per fragment. In addition, since NJ's child(1) is broadcasted, it is safe to call PublishRuntimeFilters() regardless of whether the sinker is embedded or not. Moved the call outside the IF stmt. -- To view, visit http://gerrit.cloudera.org:8080/17706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c2bb5baad622051d1002c9c162c672d428e5446 Gerrit-Change-Number: 17706 Gerrit-PatchSet: 27 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 20:16:43 +0000 Gerrit-HasComments: Yes
