Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 )
Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans ...................................................................... Patch Set 25: (7 comments) http://gerrit.cloudera.org:8080/#/c/17706/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17706/20//COMMIT_MSG@9 PS20, Line 9: patch e > Done Done http://gerrit.cloudera.org:8080/#/c/17706/20//COMMIT_MSG@10 PS20, Line 10: one val > Done Done http://gerrit.cloudera.org:8080/#/c/17706/20//COMMIT_MSG@30 PS20, Line 30: ddedBuil > Done Done http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/exec/nested-loop-join-builder.h File be/src/exec/nested-loop-join-builder.h: http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/exec/nested-loop-join-builder.h@104 PS20, Line 104: TupleRow* build_row = build_batch_iter.Get(); > Good point. Done http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/exec/nested-loop-join-builder.cc File be/src/exec/nested-loop-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/exec/nested-loop-join-builder.cc@157 PS20, Line 157: > Reworked the code in this area. It turns out the boolean flag can be comput Done http://gerrit.cloudera.org:8080/#/c/17706/20/be/src/exec/nested-loop-join-builder.cc@259 PS20, Line 259: > Done Done http://gerrit.cloudera.org:8080/#/c/17706/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/17706/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1073 PS20, Line 1073: > Yes, the flag on scalar subquery now is set to InlineViewRef in analyzer an Done -- To view, visit http://gerrit.cloudera.org:8080/17706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c2bb5baad622051d1002c9c162c672d428e5446 Gerrit-Change-Number: 17706 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:26:50 +0000 Gerrit-HasComments: Yes
