Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17711 )
Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing ...................................................................... Patch Set 2: One general comment for better code structuring is that parsing and validation logic for temporary paths can be moved to `TmpDir`. We can have inherited HdfsTmpDir, S3TmpDir etc which can have custom logic for their filesystem like enforcing port number in Hdfs paths, not having port number in S3 paths etc. It would then be easier if we need to add more custom logic in future for object stores like Azure Blob Store, GCS, Minio etc. -- To view, visit http://gerrit.cloudera.org:8080/17711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26393922811137278046bf82d4988ab832944f02 Gerrit-Change-Number: 17711 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 09:11:32 +0000 Gerrit-HasComments: No
