Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17720 )

Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc
File be/src/runtime/tmp-file-mgr-test.cc:

http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc@1021
PS2, Line 1021:   auto dirs1 = GetTmpRemoteDir(
> If there is no local buffer, is that case not supported? Either way we shou
Added.


http://gerrit.cloudera.org:8080/#/c/17720/2/be/src/runtime/tmp-file-mgr-test.cc@1031
PS2, Line 1031:   auto dirs3 = GetTmpRemoteDir(
> Is one remote dir and multiple local dirs valid configuration? In that case
Yes, we support multiple local dirs. Added a new test.



--
To view, visit http://gerrit.cloudera.org:8080/17720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0882ed1e80b02724dd5cb3cdb1fa7b6c2debcbf4
Gerrit-Change-Number: 17720
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Wed, 11 Aug 2021 05:41:41 +0000
Gerrit-HasComments: Yes

Reply via email to