Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17720 )
Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing ...................................................................... Patch Set 3: (6 comments) Looks great! http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@289 PS3, Line 289: is abandoned nit: "is not used" may sound better. Abandon implies it has been used before. http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@300 PS3, Line 300: Directory nit. "Extra remote directory" would make the warning more clear. http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@301 PS3, Line 301: is abandoned nit. same comment as above. http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@329 PS3, Line 329: S3 address is correct Do we need to verify it here as we do for hdfs? http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@436 PS3, Line 436: toks_max_size nit. max_num_tokens would be better. http://gerrit.cloudera.org:8080/#/c/17720/3/be/src/runtime/tmp-file-mgr.cc@465 PS3, Line 465: -1, remove. -- To view, visit http://gerrit.cloudera.org:8080/17720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0882ed1e80b02724dd5cb3cdb1fa7b6c2debcbf4 Gerrit-Change-Number: 17720 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 18:06:12 +0000 Gerrit-HasComments: Yes
