Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17720 )
Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing ...................................................................... Patch Set 4: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/17720/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17720/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing It's a bit confusing. Could we change this to something like: "Add support for specifying HDFS path in 'scratch_dirs' startup option" "Add support for parsing HDFS path in 'scratch_dirs' startup option" http://gerrit.cloudera.org:8080/#/c/17720/4//COMMIT_MSG@9 PS4, Line 9: We support the HDFS scratch space, but only as a test-only feature Nit: only can be removed. http://gerrit.cloudera.org:8080/#/c/17720/4//COMMIT_MSG@22 PS4, Line 22: In the patch, the new format of HDFS scratch path is Nit: In the patch -> In this patch http://gerrit.cloudera.org:8080/#/c/17720/4//COMMIT_MSG@29 PS4, Line 29: not only a test function anymore Nit: not a test only function anymore -- To view, visit http://gerrit.cloudera.org:8080/17720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0882ed1e80b02724dd5cb3cdb1fa7b6c2debcbf4 Gerrit-Change-Number: 17720 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 16 Aug 2021 17:05:31 +0000 Gerrit-HasComments: Yes
