Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 9: (25 comments) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@305 PS9, Line 305: throws CatalogException, MetastoreNotificationException, ImpalaRuntimeException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@297 PS9, Line 297: private final String SYNC_TABLE_LATEST_EVENT_ID_ERR_MSG = "Failed to sync table %s to " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@538 PS9, Line 538: public void create_table_with_constraints(org.apache.hadoop.hive.metastore.api.Table table, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@540 PS9, Line 540: List<SQLUniqueConstraint> sqlUniqueConstraints, List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@541 PS9, Line 541: List<SQLDefaultConstraint> sqlDefaultConstraints, List<SQLCheckConstraint> sqlCheckConstraints) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@564 PS9, Line 564: public void create_table_with_environment_context(org.apache.hadoop.hive.metastore.api.Table table, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@756 PS9, Line 756: boolean response = super.drop_partition_by_name(dbname, tblname, partName, deleteData); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@811 PS9, Line 811: if (!catalog_.tryWriteLock(new org.apache.impala.catalog.Table[] {srcTbl, destinationTbl})) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@880 PS9, Line 880: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@887 PS9, Line 887: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1140 PS9, Line 1140: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1222 PS9, Line 1222: MetastoreEvents.AlterTableEvent alterEvent = (MetastoreEvents.AlterTableEvent) event; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1227 PS9, Line 1227: TTableName oldTTable = new TTableName(oldMsTable.getDbName(), oldMsTable.getTableName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1228 PS9, Line 1228: TTableName newTTable = new TTableName(newMsTable.getDbName(), newMsTable.getTableName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1234 PS9, Line 1234: throw new CatalogException("failed to rename table " + oldTTable + " to " + newTTable + " " + line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1240 PS9, Line 1240: DeleteEventLog.getTblKey(oldTTable.getDb_name(), oldTTable.getTable_name())); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1276 PS9, Line 1276: renameTable(currentEventId, newTable.getDbName(), newTable.getTableName(), apiName); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1282 PS9, Line 1282: getTableAndAcquireWriteLock(newTable.getDbName(), newTable.getTableName(), apiName); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3140 PS9, Line 3140: LOG.debug("db {} does not exist in metastore. Removing it from catalog if exists ", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2510 PS9, Line 2510: String tblName, Map<String, String> params, boolean isPartitioned) throws TException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2635 PS9, Line 2635: public static void createTableFromImpala(CatalogOpExecutor catalogOpExecutor, String dbName, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3202 PS9, Line 3202: public static void addPartitions(MetaStoreClient msClient, String dbName, String tblName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@156 PS9, Line 156: catalogHmsClient_.dropPartition(TEST_DB_NAME, tblName, Arrays.asList("3"), true); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@157 PS9, Line 157: assertTrue("Table should have 2 partitions after dropping 1 out of 3 partitions", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/9/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@276 PS9, Line 276: private void createDatabaseInHms(String catName, String dbName, Map<String, String> params) line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 9 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 18 Aug 2021 16:27:51 +0000 Gerrit-HasComments: Yes
