Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@427 PS5, Line 427: new CatalogException("Couldn't acquire write lock on db: " + db.getName()), apiName); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@478 PS5, Line 478: List<SQLForeignKey> sqlForeignKeys, List<SQLUniqueConstraint> sqlUniqueConstraints, line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@479 PS5, Line 479: List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@480 PS5, Line 480: List<SQLDefaultConstraint> sqlDefaultConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@625 PS5, Line 625: boolean response = super.drop_partition_by_name(dbname, tblname, partName, deleteData); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@681 PS5, Line 681: if (!catalog_.tryWriteLock(new org.apache.impala.catalog.Table[] {srcTbl, destinationTbl})) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@750 PS5, Line 750: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@757 PS5, Line 757: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@775 PS5, Line 775: org.apache.impala.catalog.Table tbl = getTableAndAcquireWriteLock(alterPartitionsRequest.getDbName(), line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@980 PS5, Line 980: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2499 PS5, Line 2499: String tblName, Map<String, String> params, boolean isPartitioned) throws TException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3181 PS5, Line 3181: public static void addPartitions(MetaStoreClient msClient, String dbName, String tblName, line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 5 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 19:05:13 +0000 Gerrit-HasComments: Yes
