Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 6: (17 comments) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@305 PS6, Line 305: throws CatalogException, MetastoreNotificationException, ImpalaRuntimeException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@427 PS6, Line 427: new CatalogException("Couldn't acquire write lock on db: " + db.getName()), apiName); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@514 PS6, Line 514: List<SQLForeignKey> sqlForeignKeys, List<SQLUniqueConstraint> sqlUniqueConstraints, line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@515 PS6, Line 515: List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@516 PS6, Line 516: List<SQLDefaultConstraint> sqlDefaultConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@661 PS6, Line 661: boolean response = super.drop_partition_by_name(dbname, tblname, partName, deleteData); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@717 PS6, Line 717: if (!catalog_.tryWriteLock(new org.apache.impala.catalog.Table[] {srcTbl, destinationTbl})) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@786 PS6, Line 786: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@793 PS6, Line 793: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@811 PS6, Line 811: org.apache.impala.catalog.Table tbl = getTableAndAcquireWriteLock(alterPartitionsRequest.getDbName(), line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1017 PS6, Line 1017: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2504 PS6, Line 2504: String tblName, Map<String, String> params, boolean isPartitioned) throws TException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2629 PS6, Line 2629: public static void createTableFromImpala(CatalogOpExecutor catalogOpExecutor, String dbName, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3196 PS6, Line 3196: public static void addPartitions(MetaStoreClient msClient, String dbName, String tblName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@118 PS6, Line 118: MetastoreEventsProcessorTest.createDatabaseFromImpala(catalogOpExecutor_, TEST_DB_NAME, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@121 PS6, Line 121: //MetastoreEventsProcessorTest.createTableFromImpala(catalogOpExecutor_, TEST_DB_NAME, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/6/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@123 PS6, Line 123: catalogHmsClient_.createTable(MetastoreEventsProcessorTest.getTestTable(null, TEST_DB_NAME, line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 6 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 16:46:04 +0000 Gerrit-HasComments: Yes
