Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 )
Change subject: IMPALA-10921 Add script to compare TPCDS runs. ...................................................................... Patch Set 1: (39 comments) http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py File bin/diagnostics/experimental/tpcds_run_comparator.py: http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@44 PS1, Line 44: class Task(Enum): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@72 PS1, Line 72: def debug(s): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@76 PS1, Line 76: def geo_mean(bytes): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@79 PS1, Line 79: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@81 PS1, Line 81: def str_to_byte(line): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@96 PS1, Line 96: class ProfileParser: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@105 PS1, Line 105: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@106 PS1, Line 106: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@107 PS1, Line 107: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@108 PS1, Line 108: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@108 PS1, Line 108: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@110 PS1, Line 110: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@169 PS1, Line 169: c flake8: E999 SyntaxError: invalid syntax http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@181 PS1, Line 181: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@184 PS1, Line 184: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@184 PS1, Line 184: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@185 PS1, Line 185: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@185 PS1, Line 185: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@192 PS1, Line 192: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@194 PS1, Line 194: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@196 PS1, Line 196: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@198 PS1, Line 198: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@202 PS1, Line 202: / flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@203 PS1, Line 203: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@204 PS1, Line 204: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@205 PS1, Line 205: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@205 PS1, Line 205: * flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@211 PS1, Line 211: def print_results(ht_mem_res, op_mem_res): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@227 PS1, Line 227: def is_dir(path): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@232 PS1, Line 232: def main(): flake8: E302 expected 2 blank lines, found 0 http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@246 PS1, Line 246: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@246 PS1, Line 246: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@248 PS1, Line 248: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@262 PS1, Line 262: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 0 -- To view, visit http://gerrit.cloudera.org:8080/17855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e9ae1a2919156b0022072f47ff71d7775b20e6 Gerrit-Change-Number: 17855 Gerrit-PatchSet: 1 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 19 Sep 2021 23:16:37 +0000 Gerrit-HasComments: Yes
