Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 )
Change subject: IMPALA-10921 Add script to compare TPCDS runs. ...................................................................... Patch Set 1: (5 comments) Thanks for adding using useful tools to the repository! http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py File bin/diagnostics/experimental/tpcds_run_comparator.py: http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@57 PS1, Line 57: SECTIONS = [ nit: could you please add some comments for SECTIONS? It's a bit misleading to use the next section's first line to mark the end of the current section. http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@93 PS1, Line 93: byte *= 1024**3 Maybe raise an error for unknown 'unit'. http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@132 PS1, Line 132: if len(parts) == 7: Could you add some comments here? http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@180 PS1, Line 180: < maybe it would be interesting to see if there was an increase in some cases. http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@231 PS1, Line 231: "{path} is not a valid path needs format? -- To view, visit http://gerrit.cloudera.org:8080/17855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e9ae1a2919156b0022072f47ff71d7775b20e6 Gerrit-Change-Number: 17855 Gerrit-PatchSet: 1 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Sep 2021 16:02:47 +0000 Gerrit-HasComments: Yes
