Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 )
Change subject: IMPALA-10921 Add script to compare TPCDS runs. ...................................................................... Patch Set 1: (2 comments) Hi Amogh, Thanks for submitting the script. Besides the flake8 errors, I have few comments and request to incorporate. http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py File bin/diagnostics/experimental/tpcds_run_comparator.py: http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@211 PS1, Line 211: def print_results(ht_mem_res, op_mem_res): It will be great if we can add option to print this output to 2 csv files. http://gerrit.cloudera.org:8080/#/c/17855/1/bin/diagnostics/experimental/tpcds_run_comparator.py@245 PS1, Line 245: if (i == 23 or i == 24): : filenames = [str(i)+"_a.txt", str(i)+"_b.txt"] For iterating the profiles, what if we just use simple filename matching between the baseline dir and new measurement dir? The reason is that the naming convention is not always standardized. I have seen variation such as '23_a.txt', '23a.txt', 'tpcds-23a.txt', and so on. Using simple filename match will also make the script more general, not specific to just TPC-DS. -- To view, visit http://gerrit.cloudera.org:8080/17855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e9ae1a2919156b0022072f47ff71d7775b20e6 Gerrit-Change-Number: 17855 Gerrit-PatchSet: 1 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Sep 2021 18:17:56 +0000 Gerrit-HasComments: Yes
