Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17872 )

Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB 
forever
......................................................................


Patch Set 30:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17872/29/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

http://gerrit.cloudera.org:8080/#/c/17872/29/tests/hs2/test_hs2.py@368
PS29, Line 368:     # and measure the time spent. Should be less than 3s.
              :     start = time.time()
              :     execute_statement_resp = self.execute_statement(
> Take a timestamp before this statement and after, then take the diff and ma
Done


http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_ddl.py@903
PS29, Line 903: # IMPALA-10811: RPC to submit query getting stuck for AWS NLB 
forever
              : # Test HS2, Beeswax and HS2-HTTP three clients.
              : class TestAsyncDDL(TestDdlBase):
              :   @classmethod
              :   def get_workload(self):
              :     return 'functional-query'
              :
              :   @classmethod
              :   def add_test_dimensions(cls):
              :     super(TestAsyncDDL, cls).add_test_dimensions()
              :     
cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
              :     
cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension(
              :         sync_ddl=[0]))
              :
              :   def test_async_ddl(self, vector, unique_database):
              :     self.run_test_case('QueryTest/async_ddl', vector, 
use_db=unique_database)
> Create an test in tests/hs2/test_hs2.py that does the equivalent of test_ge
The purpose of this test is to check out 3 different clients.

Tests in test_hs2.py checks out HS2 only.

class TestHS2(HS2TestSuite):

110                                                 
111 class HS2TestSuite(ImpalaTestSuite):
112   HS2_V6_COLUMN_TYPES = ['boolVal', 'stringVal', 'byteVal', 'i16Val', 
'i32Val', 'i64Val',
113                          'doubleVal', 'binaryVal']        
114                                      
115   def setup(self):                                                          
               
116     self.socket, self.hs2_client = self._open_hs2_connection()
117                                          
118   def teardown(self):
119     if self.socket:                                                     
120       self.socket.close()                      
121


http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_metadata_query_statements.py
File tests/metadata/test_metadata_query_statements.py:

http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_metadata_query_statements.py@153
PS29, Line 153:   def test_async_ddl_with_JDBC(self, vector, unique_database):
              :     self.exec_with_jdbc("drop table if exists 
{0}.test_table".format(unique_database))
              :     self.exec_with_jdbc_and_compare_result(
              :         "create table {0}.test_table(a 
int)".format(unique_database),
              :         "'Table has been created.'")
              :
              :     self.exec_with_jdbc("drop table if exists 
{0}.alltypes_clone".format(unique_database))
              :     self.exec_with_jdbc_and_compare_result(
              :         "create table {0}.alltypes_clone as select * from\
              :         functional_parquet.alltypes".format(unique_database),
              :         "'Inserted 7300 row(s)'")
> Metadata query statements are things like "describe {table_name}" and "desc
It looks like the compiled java code for JDBC is based on the standard JDBC 
implementation:

https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java#L26

The core command used under the table is

('cmd=', '/home/qchen/Impala.07202021/bin/run-jdbc-client.sh -i 
"localhost:21050" -t NOSASL -q "create table test_async_ddl_with_JDBC_bc95b

run-jdbc-client.sh is the following.

20 . ${IMPALA_HOME}/bin/set-classpath.sh test                                   
        
 21 CLASSPATH=${IMPALA_JDBC_DRIVER_CLASSPATH}:${CLASSPATH}        
 22 "$JAVA" -cp $CLASSPATH org.apache.impala.testutil.ImpalaJdbcClient "$@"



--
To view, visit http://gerrit.cloudera.org:8080/17872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e
Gerrit-Change-Number: 17872
Gerrit-PatchSet: 30
Gerrit-Owner: Qifan Chen <[email protected]>
Gerrit-Reviewer: Amogh Margoor <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Comment-Date: Tue, 19 Oct 2021 20:50:40 +0000
Gerrit-HasComments: Yes

Reply via email to