Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 31: (2 comments) Address all review comments and add the query option enable_async_ddl_execution. http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_ddl.py@903 PS29, Line 903: : # IMPALA-10811: RPC to submit query getting stuck for AWS NLB forever : # Test HS2, Beeswax and HS2-HTTP three clients. : class TestAsyncDDL(TestDdlBase): : @classmethod : def get_workload(self): : return 'functional-query' : : @classmethod : def add_test_dimensions(cls): : super(TestAsyncDDL, cls).add_test_dimensions() : cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension()) : cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension( : sync_ddl=[0], disable_codegen_options=[False])) : : def test_async_ddl(self, vector, unique_database): > As with the JDBC test, the way I'm thinking about this test is whether this Removed CTAS test from async_ddl and replaced it with the state transition test for three clients here. Retain only alter table recover partition test in async_ddl. Done. http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: http://gerrit.cloudera.org:8080/#/c/17872/29/tests/metadata/test_metadata_query_statements.py@153 PS29, Line 153: @pytest.mark.execute_serially # due to data src setup/teardown : @SkipIfCatalogV2.data_sources_unsupported() : def test_show_data_sources(self, vector): : try: : self.__create_data_sources() : self.run_test_case('QueryTest/show-data-sources', vector) : finally: : self.__drop_data_sources() : : def __drop_data_sources(self): : for name in self.TEST_DATA_SR > The 21050 port is the HS2 port. Since we claim that the protocol does not change with the patch, this is a functional test for JDBC client. We have similar tests for HS2, BW and HS2-http. By looking at JDBC driver setup for other vendors, it seems one can set the port in the URL connection string. See one example here https://www.baeldung.com/java-jdbc-url-format. In the invocation of Impala JDBC client, the port number is set to 21050. So it is very likely (without real code to look at) that the Impala JDBC client is capable of talking to impala hs2 server. ('cmd=', '/home/qchen/Impala.07202021/bin/run-jdbc-client.sh -i "localhost:21050" -t NOSASL -q "drop table if exists test_async_ddl_with_JD BC_bc95ba92.foo;"') -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 31 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Wed, 20 Oct 2021 21:44:26 +0000 Gerrit-HasComments: Yes
