Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18041 )
Change subject: IMPALA-11022: Impala uses wrong file descriptors for Iceberg tables in local catalog mode ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/18041/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18041/1//COMMIT_MSG@18 PS1, Line 18: block locations remain consisten. t http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@455 PS1, Line 455: } else { precondition about hostIndex != null? http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1014 PS1, Line 1014: //return resp.table_info.getIceberg_snapshot(); code in comment http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/util/ListMap.java File fe/src/main/java/org/apache/impala/util/ListMap.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/util/ListMap.java@56 PS1, Line 56: public int getOrAddIndex(T t) { can you add a comment about this rename in the comment, or possibly move it to a different patch? I agree with the rename as the old name was misleading, but it adds some extra noise to the commit -- To view, visit http://gerrit.cloudera.org:8080/18041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I253b505846e1cf4d1be445c0d06b2552dc4ba1f8 Gerrit-Change-Number: 18041 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 19 Nov 2021 16:14:21 +0000 Gerrit-HasComments: Yes
