Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18041 )
Change subject: IMPALA-11022: Impala uses wrong file descriptors for Iceberg tables in local catalog mode ...................................................................... Patch Set 3: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/18041/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18041/2//COMMIT_MSG@12 PS2, Line 12: but the hosts are only referred to by indexes. In the Coordinator's > nit: referred to Done http://gerrit.cloudera.org:8080/#/c/18041/2//COMMIT_MSG@17 PS2, Line 17: This patch properly translates the host index to the coordinators host > nit properly Done http://gerrit.cloudera.org:8080/#/c/18041/2//COMMIT_MSG@21 PS2, Line 21: manually > nit. I wonder if it is feasible to have a query test to protect this piece I was able to add a unit test. http://gerrit.cloudera.org:8080/#/c/18041/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18041/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@458 PS2, Line 458: Des > may need to check fd is not null. Done http://gerrit.cloudera.org:8080/#/c/18041/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18041/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@111 PS2, Line 111: snapshot > Should we check snapshot is null? loadIcebergSnapshot() shouldn't return null, but added Preconditions check anyway. -- To view, visit http://gerrit.cloudera.org:8080/18041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I253b505846e1cf4d1be445c0d06b2552dc4ba1f8 Gerrit-Change-Number: 18041 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 22 Nov 2021 14:51:30 +0000 Gerrit-HasComments: Yes
