Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18041 )
Change subject: IMPALA-11022: Impala uses wrong file descriptors for Iceberg tables in local catalog mode ...................................................................... Patch Set 2: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/18041/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18041/1//COMMIT_MSG@18 PS1, Line 18: block locations remain consistent. > t Done http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@455 PS1, Line 455: } else { > precondition about hostIndex != null? Done http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1014 PS1, Line 1014: Map<String, FileDescriptor> pathToFds = > code in comment Done http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@500 PS1, Line 500: new TScanRangeLocation(analyzer.getHostIndex().getIndex(networkAddress))); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/util/ListMap.java File fe/src/main/java/org/apache/impala/util/ListMap.java: http://gerrit.cloudera.org:8080/#/c/18041/1/fe/src/main/java/org/apache/impala/util/ListMap.java@56 PS1, Line 56: public int getIndex(T t) { > can you add a comment about this rename in the comment, or possibly move it Opened IMPALA-11031 -- To view, visit http://gerrit.cloudera.org:8080/18041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I253b505846e1cf4d1be445c0d06b2552dc4ba1f8 Gerrit-Change-Number: 18041 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 19 Nov 2021 16:31:21 +0000 Gerrit-HasComments: Yes
