[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18091 )

Change subject: IMPALA-11057: Speed to hex_int function
......................................................................


Patch Set 5:

(2 comments)

Hi, is there anything i need to do now?

http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc
File be/src/exprs/math-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc@242
PS4, Line 242:   static const char hex[] = {'0', '1', '2', '3', '4', '5', 
'6','7',
> Declare static const
Done


http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc@254
PS4, Line 254:   // reverse
> Wrap with:
Done



--
To view, visit http://gerrit.cloudera.org:8080/18091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2dc7ea64b60b24f1a9e6ab53725acd40ce88ac
Gerrit-Change-Number: 18091
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Comment-Date: Thu, 16 Dec 2021 02:18:44 +0000
Gerrit-HasComments: Yes

Reply via email to