Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 )
Change subject: IMPALA-11057: Speed up hex_int function ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18091/7/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18091/7/be/src/exprs/math-functions-ir.cc@263 PS7, Line 263: ans.Resize(ctx, i); You don't need to include the '\0' in StringVal. So you can truncate it to i-1 here. -- To view, visit http://gerrit.cloudera.org:8080/18091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2dc7ea64b60b24f1a9e6ab53725acd40ce88ac Gerrit-Change-Number: 18091 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 16 Dec 2021 18:15:30 +0000 Gerrit-HasComments: Yes
