[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18091 )

Change subject: IMPALA-11057: Speed up hex_int function
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18091/5/be/src/exprs/math-functions-ir.cc
File be/src/exprs/math-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/18091/5/be/src/exprs/math-functions-ir.cc@246
PS5, Line 246:   StringVal ans
> You can write the result immediately to StringVal struct to avoid unnecessa
That's great!



-- 
To view, visit http://gerrit.cloudera.org:8080/18091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2dc7ea64b60b24f1a9e6ab53725acd40ce88ac
Gerrit-Change-Number: 18091
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 16 Dec 2021 14:05:23 +0000
Gerrit-HasComments: Yes

Reply via email to