Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 12: (26 comments) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@283 PS12, Line 283: chunked_boundary_ = start_pos_ + column->chunk(chunk_pos_)->length(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@284 PS12, Line 284: // VLOG_QUERY << "i:" << i << "num_rows_" << num_rows_ << "chunked boundary" << chunked_boundary_ << "start_pos_" << start_pos_; line too long (134 > 90) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@285 PS12, Line 285: if(i == chunked_boundary_){ line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@289 PS12, Line 289: VLOG_QUERY << "start pos" << start_pos_ << "chunk pos"<< chunk_pos_ << "length" << column->chunk(chunk_pos_)->length(); line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@312 PS12, Line 312: DCHECK(s_arr.IsValid(i - start_pos_)) << "length: " << s_arr.length() << ", offset: " << s_arr.offset(); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@313 PS12, Line 313: int src_len = s_arr.value_length(i - start_pos_); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@315 PS12, Line 315: char* src_ptr; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@318 PS12, Line 318: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@319 PS12, Line 319: // auto blob = s_arr.value_data(); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@322 PS12, Line 322: char* blob_; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@323 PS12, Line 323: // VLOG_QUERY << blob->data() << "blob data and size" << blob->size(); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@325 PS12, Line 325: DCHECK(src_len>0)<< "i for size error" << i << "len" <<src_len << "length: " << s_arr.length() << ", offset: " << s_arr.offset(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@325 PS12, Line 325: DCHECK(src_len>0)<< "i for size error" << i << "len" <<src_len << "length: " << s_arr.length() << ", offset: " << s_arr.offset(); line too long (138 > 90) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@326 PS12, Line 326: blob_ = reinterpret_cast<char*>(pool->TryAllocateUnaligned(src_len)); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@327 PS12, Line 327: // memcpy(blob_, blob->data(), blob->size()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@329 PS12, Line 329: // char* src_ptr; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@332 PS12, Line 332: auto val_char = reinterpret_cast<const char*>(val); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@335 PS12, Line 335: //src_ptr = blob_ + (val - blob->data()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@336 PS12, Line 336: //src_ptr = s_arr.GetString(i); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@337 PS12, Line 337: // auto str = s_arr.GetString(i); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@338 PS12, Line 338: memcpy(blob_, val_char, src_len); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@339 PS12, Line 339: // VLOG_QUERY << "val" << val_char << "len" << src_len; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@340 PS12, Line 340: //src_ptr = reinterpret_cast<char*>(s_arr.GetView(i)); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@341 PS12, Line 341: src_ptr = blob_; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@342 PS12, Line 342: if (src_len == 0) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/17771/12/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17771/12/bin/bootstrap_toolchain.py@469 PS12, Line 469: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 20 Dec 2021 05:15:46 +0000 Gerrit-HasComments: Yes
