Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@187 PS12, Line 187: std::shared_ptr<arrow::json::TableReader> reader; > do you mean reader field, it used on line 193. No, I mean 'reader_' in HdfsJsonScanner (line 139 in hdfs-json-scanner.h) -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:02:29 +0000 Gerrit-HasComments: Yes
