Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@187 PS12, Line 187: std::shared_ptr<arrow::json::TableReader> reader; There is a 'reader_' field but we never use it. I'm confused about the lifetime of arrow::json::TableReader, ArrowMemPool and arrow::Table. Not sure if they will be destroyed in a correct order. http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@190 PS12, Line 190: new ArrowMemPool Will the destructor of arrow::json::TableReader destroys the mem pool? If not, we are leaking the ArrowMemPool object. http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@192 PS12, Line 192: if (res.ok()) { Shouldn't we handle non-ok status? -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 20 Dec 2021 13:35:21 +0000 Gerrit-HasComments: Yes
