[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 )
Change subject: IMPALA-11057: Speed up hex_int function ...................................................................... Patch Set 8: (2 comments) Hi, is there anything i can do for this PR? http://gerrit.cloudera.org:8080/#/c/18091/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18091/7//COMMIT_MSG@9 PS7, Line 9: The origin HexInt method is too slow. : Because the format conv > minor nit: you can elaborate more on what the problem was, and how it was f Done http://gerrit.cloudera.org:8080/#/c/18091/7/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18091/7/be/src/exprs/math-functions-ir.cc@250 PS7, Line 250: ptr[i] = hex[num & 15]; > You can use array index with ptr here, such as: Done -- To view, visit http://gerrit.cloudera.org:8080/18091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2dc7ea64b60b24f1a9e6ab53725acd40ce88ac Gerrit-Change-Number: 18091 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 29 Dec 2021 08:57:50 +0000 Gerrit-HasComments: Yes
