Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18210 )
Change subject: IMPALA-955: BYTES built-in function ...................................................................... Patch Set 1: (4 comments) LGTM. Could you also add an end-to-end test in testdata/workloads/functional-query/queries/QueryTest/exprs.test (used by tests/query_test/test_exprs.py)? E.g. select bytes(string_col), bytes(date_string_col) from alltypestiny; You can run the individual test by impala-py.test tests/query_test/test_exprs.py::TestExprs::test_exprs http://gerrit.cloudera.org:8080/#/c/18210/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18210/1//COMMIT_MSG@9 PS1, Line 9: The Bytes function returns the number of bytes contained in the specified byte string. : There are changes in 4 files.A few testcases are also added in Impala/be/src/exprs/expr-test.cc. nit: please format the commit message body to have no more than 72 chars in each line. Add one space after each period. https://dev.to/noelworden/improving-your-commit-message-with-the-50-72-rule-3g79 http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/expr-test.cc@10716 PS1, Line 10716: nit: please remove the empty line here. http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/string-functions-ir.cc@264 PS1, Line 264: nit: please remove empty lines http://gerrit.cloudera.org:8080/#/c/18210/1/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/18210/1/common/function-registry/impala_functions.py@510 PS1, Line 510: Bytes nit: use lowercase as other lines. Please add one space after commas. -- To view, visit http://gerrit.cloudera.org:8080/18210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bd06c3d6dba354d71f63c649eaa8f9f74d266ee Gerrit-Change-Number: 18210 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 08 Feb 2022 05:42:11 +0000 Gerrit-HasComments: Yes
