[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18210 )

Change subject: IMPALA-955: BYTES built-in function
......................................................................


Patch Set 2:

> Patch Set 1:
>
> (4 comments)
>
> LGTM. Could you also add an end-to-end test in 
> testdata/workloads/functional-query/queries/QueryTest/exprs.test (used by 
> tests/query_test/test_exprs.py)? E.g.
>
>  select bytes(string_col), bytes(date_string_col) from alltypestiny;
>
> You can run the individual test by
>
>  impala-py.test tests/query_test/test_exprs.py::TestExprs::test_exprs

done!


--
To view, visit http://gerrit.cloudera.org:8080/18210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd06c3d6dba354d71f63c649eaa8f9f74d266ee
Gerrit-Change-Number: 18210
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:38:11 +0000
Gerrit-HasComments: No

Reply via email to