[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18210 )
Change subject: IMPALA-955: BYTES built-in function ...................................................................... Patch Set 3: (5 comments) > Patch Set 2: Code-Review+1 > > (1 comment) > > LGTM http://gerrit.cloudera.org:8080/#/c/18210/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18210/1//COMMIT_MSG@9 PS1, Line 9: The Bytes function returns the number of bytes contained : in the specified byte string. There are changes in > nit: please format the commit message body to have no more than 72 chars in Done http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/expr-test.cc@10716 PS1, Line 10716: TEST_P(ExprTest, Utf8Test) { > nit: please remove the empty line here. Done http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18210/1/be/src/exprs/string-functions-ir.cc@264 PS1, Line 264: } > nit: please remove empty lines Done http://gerrit.cloudera.org:8080/#/c/18210/1/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/18210/1/common/function-registry/impala_functions.py@510 PS1, Line 510: bytes > nit: use lowercase as other lines. Please add one space after commas. Done http://gerrit.cloudera.org:8080/#/c/18210/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/18210/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3219 PS2, Line 3219: > nit: please remove the redudant empty lines. Resolved -- To view, visit http://gerrit.cloudera.org:8080/18210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bd06c3d6dba354d71f63c649eaa8f9f74d266ee Gerrit-Change-Number: 18210 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 09 Feb 2022 09:51:13 +0000 Gerrit-HasComments: Yes
