Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18155 )
Change subject: IMPALA-10931 (part2): Fixed rebased Kudu source to compile ...................................................................... Patch Set 5: (5 comments) I compared this to our previous changes impacting the checked in Kudu source (IMPALA-9335, IMPALA-9940, etc). Everything lines up nicely, and this is looking good. There are a couple things that look new that I would like to make sure I understand. http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/test/mini_kdc.cc File be/src/kudu/security/test/mini_kdc.cc: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/test/mini_kdc.cc@314 PS5, Line 314: string tmp_username = username; : StripString(&tmp_username, "/", '_'); : const auto tmp_template = Substitute("kinit-temp-$0.XXXXXX", tmp_username); For myself: This is new, but it makes sense that we wouldn't want / in the template to avoid subdirectories. http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/tls_handshake.cc File be/src/kudu/security/tls_handshake.cc: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/tls_handshake.cc@316 PS5, Line 316: const uint8_t* data = reinterpret_cast<const uint8_t*>(rbio_pending_data_.data()); This looks new. What does this do? http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/util/random_util.h File be/src/kudu/util/random_util.h: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/util/random_util.h@30 PS5, Line 30: // Inline functions defined in int128_util.h cause ambiguous overload error for : // std::ostream& operator<<(std::ostream& os, const unsigned __int128& val), : // include "kudu/util/int128.h" instead. : #include "kudu/util/int128.h" New, seems ok as long as it compiles/works. http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/rpc/sidecar-util.h File be/src/rpc/sidecar-util.h: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/rpc/sidecar-util.h@85 PS5, Line 85: kudu::faststring sidecar_str; : sidecar_str.assign_copy(serialized_buf, serialized_len); This looks new. What does this do? http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/runtime/query-state.cc@676 PS5, Line 676: kudu::faststring sidecar_buf; : sidecar_buf.assign_copy(profile_buf, profile_len); This looks new. What does this do? -- To view, visit http://gerrit.cloudera.org:8080/18155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7 Gerrit-Change-Number: 18155 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 18:53:20 +0000 Gerrit-HasComments: Yes
