Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18155 )
Change subject: IMPALA-10931 (part2): Fixed rebased Kudu source to compile ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/rpc/sidecar-util.h File be/src/rpc/sidecar-util.h: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/rpc/sidecar-util.h@85 PS5, Line 85: kudu::faststring sidecar_str; : sidecar_str.assign_copy(serialized_buf, serialized_len); > Parameter type of kudu::rpc::RpcSidecar::FromFaststring() was changed from RpcSidecar::FromFaststring() make copy of input string so this code change is safe. -- To view, visit http://gerrit.cloudera.org:8080/18155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7 Gerrit-Change-Number: 18155 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 19:46:02 +0000 Gerrit-HasComments: Yes
