Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18155 )
Change subject: IMPALA-10931 (part2): Fixed rebased Kudu source to compile ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/test/mini_kdc.cc File be/src/kudu/security/test/mini_kdc.cc: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/test/mini_kdc.cc@314 PS5, Line 314: string tmp_username = username; : StripString(&tmp_username, "/", '_'); : const auto tmp_template = Substitute("kinit-temp-$0.XXXXXX", tmp_username); > The implementation of MiniKdc::Kinit() was changed. In be/src/rpc/rpc-mgr-k I will ask Kudu team to make this change so we don't need to change Kudu code in next rebase. http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/tls_handshake.cc File be/src/kudu/security/tls_handshake.cc: http://gerrit.cloudera.org:8080/#/c/18155/5/be/src/kudu/security/tls_handshake.cc@316 PS5, Line 316: const uint8_t* data = reinterpret_cast<const uint8_t*>(rbio_pending_data_.data()); > The first parameter type of Socket.Write() is "const uint8_t *". Got warnin I will ask Kudu team to make this change so we don't need to change Kudu code in next rebase. -- To view, visit http://gerrit.cloudera.org:8080/18155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7 Gerrit-Change-Number: 18155 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 19:49:50 +0000 Gerrit-HasComments: Yes
