Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@381 PS2, Line 381: private boolean hasJSON(Set<HdfsFileFormat> fileFormat){ We just use this once. Probably not worth a method for it. http://gerrit.cloudera.org:8080/#/c/18323/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@416 PS2, Line 416: checkForSupportedFileFormats(); Could you move the check into this method? -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 11:10:22 +0000 Gerrit-HasComments: Yes
