Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@475 PS4, Line 475: S nit: need a space http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@475 PS4, Line 475: ,this nit: need a space before "this" http://gerrit.cloudera.org:8080/#/c/18323/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@484 PS4, Line 484: } Please move this block before the calculation of "firstComplexTypedCol", i.e. move it to line 467. http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py@132 PS4, Line 132: def test_json_file_unsupported(self, unique_database): This test needs to insert data via Hive, which requires a running HiveServer2. We need to skip it when running on non-HDFS builds since there are no HiveServer2 or YARN running. Import and add these skip annotations before the method: https://github.com/apache/impala/blob/80307d39976c27a7ada11e7cd776a30b09a3abdc/tests/metadata/test_hms_integration.py#L132-L138 -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 18 Mar 2022 23:40:45 +0000 Gerrit-HasComments: Yes
