Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18323 )
Change subject: IMPALA-11145: Block reads on JSON table until we support it ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@a485 PS5, Line 485: nit: add back this blank line http://gerrit.cloudera.org:8080/#/c/18323/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@485 PS5, Line 485: nit: remove this blank line http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18323/4/tests/metadata/test_hms_integration.py@132 PS4, Line 132: def test_json_file_unsupported(self, unique_database): > This test needs to insert data via Hive, which requires a running HiveServe Please ignore this since the class level already has such annotations. -- To view, visit http://gerrit.cloudera.org:8080/18323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcebf5891f8db52be442f66a8efb1724d1e545aa Gerrit-Change-Number: 18323 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 22 Mar 2022 06:43:53 +0000 Gerrit-HasComments: Yes
