Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client ...................................................................... Patch Set 4: Code-Review+2 The change inside ImpalaHttpClient looks safe and isolated. My only worry would be about changing the default value of client_connect_timeout_ms. What do we think client_connect_timeout_ms means? The description is "Timeout in milliseconds after which impala-shell will time out if it fails to connect to Impala server. Set to 0 to disable any timeout." In the hs2 case this means setting a socket timeout. And it looks like setting it to 0 should still work. in hs2-http it mean something a bit different, in that it it is now the time that we wait for a (virtual) connection to be established. And retry is layered on top of this I think. Together these make the "time for server to startup" So if we expect hs2-http to be the most important protocol going forward we could consider having separate parameters for hs2-http that more exactly match what we are doing. -- To view, visit http://gerrit.cloudera.org:8080/18336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94 Gerrit-Change-Number: 18336 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 22 Mar 2022 17:53:48 +0000 Gerrit-HasComments: No
