Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18336 )

Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout 
for http client
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py@2070
PS5, Line 2070: !
flake8: E711 comparison to None should be 'if cond is not None:'


http://gerrit.cloudera.org:8080/#/c/18336/5/shell/impala_shell.py@2071
PS5, Line 2071: 0
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/18336/5/shell/option_parser.py
File shell/option_parser.py:

http://gerrit.cloudera.org:8080/#/c/18336/5/shell/option_parser.py@276
PS5, Line 276: b
flake8: E501 line too long (98 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/18336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Gerrit-Change-Number: 18336
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:31:12 +0000
Gerrit-HasComments: Yes

Reply via email to