Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 )
Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client ...................................................................... Patch Set 6: I like the split of the options, thanks for doing that. Code looks clean. Regarding "The default value of '--http_socket_timeout_s' is set to None, to prevent behavior changes for existing clients." I understand the caution, this is definitely the safest change, but overall would users be happier if it was non-zero? I don't know the answer, I am just asking :-) -- To view, visit http://gerrit.cloudera.org:8080/18336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94 Gerrit-Change-Number: 18336 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 25 Mar 2022 18:57:22 +0000 Gerrit-HasComments: No
