Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18359 )
Change subject: IMPALA-11204: template implementation for OrcStringColumnReader ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc@919 PS2, Line 919: in case "in case" suggests that we only recreate it when there is an encoding change, but we always recreate it. I think that "to handle column encoding changes" would be clearer. http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc@922 PS2, Line 922: make_unique An alternative to recreating readers could be to override ReadValueBatch in OrcStringColumnReader and call a templated version of ReadValue from there. I don't think that this would be a better solution in general, but it could reduce the size of the change. -- To view, visit http://gerrit.cloudera.org:8080/18359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166b8ad3a959e97a3911da968b8e76bc337e5fa4 Gerrit-Change-Number: 18359 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 13:50:30 +0000 Gerrit-HasComments: Yes
