Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18359 )
Change subject: IMPALA-11204: template implementation for OrcStringColumnReader ...................................................................... Patch Set 2: (1 comment) Thank Csaba and Riza! A new approach based on Csaba's suggestion is uploaded at https://gerrit.cloudera.org/c/18366 http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc@922 PS2, Line 922: make_unique > An alternative to recreating readers could be to override ReadValueBatch in That's a much simpler approach indeed! My first choice is something similar but got stuck by some template issues. I have a try with this and the performance improvement is similar. I tend to abandon this. We can revive it if one day we need to change the life cycle of readers. -- To view, visit http://gerrit.cloudera.org:8080/18359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166b8ad3a959e97a3911da968b8e76bc337e5fa4 Gerrit-Change-Number: 18359 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 06:46:05 +0000 Gerrit-HasComments: Yes
