Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18359 )
Change subject: IMPALA-11204: template implementation for OrcStringColumnReader ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18359/2/be/src/exec/hdfs-orc-scanner.cc@203 PS2, Line 203: Status HdfsOrcScanner::StartColumnReading(const orc::StripeInformation& stripe) { Since we have 'stripe_' as a new class member in this patch, can we remove this 'stripe' parameter? -- To view, visit http://gerrit.cloudera.org:8080/18359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166b8ad3a959e97a3911da968b8e76bc337e5fa4 Gerrit-Change-Number: 18359 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 15:32:05 +0000 Gerrit-HasComments: Yes
