Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18373 )
Change subject: IMPALA-10272: LOAD DATA should respect Ranger-HDFS policies ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for fixing this! It'd be nice if we can add an end-to-end test. However, we currently don't have the script to launch HDFS with Ranger authz enabled. I just filed IMPALA-11217 for it. I'm ok to add the end-to-end test in a follow-up JIRA. I can bump my +1 to +2 after I verify the patch in a real cluster. http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java File fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java: http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java@314 PS1, Line 314: nit: indention needs 2 more spaces http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/test/java/org/apache/impala/util/FsPermissionCheckerTest.java File fe/src/test/java/org/apache/impala/util/FsPermissionCheckerTest.java: http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/test/java/org/apache/impala/util/FsPermissionCheckerTest.java@37 PS1, Line 37: Ahthz nit: Authz? The other 3 tests have the same word. -- To view, visit http://gerrit.cloudera.org:8080/18373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0acd83e8e237ea6a1d5fe1e9e440db0dd68b09c Gerrit-Change-Number: 18373 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 13:07:51 +0000 Gerrit-HasComments: Yes
