lipeng...@sensorsdata.cn has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18373 )

Change subject: IMPALA-10272: LOAD DATA should respect Ranger-HDFS policies
......................................................................


Patch Set 4:

(2 comments)

done

http://gerrit.cloudera.org:8080/#/c/18373/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18373/3//COMMIT_MSG@10
PS3, Line 10: fail
> nit: fail
Done


http://gerrit.cloudera.org:8080/#/c/18373/3/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java
File fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java:

http://gerrit.cloudera.org:8080/#/c/18373/3/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java@27
PS3, Line 27: import org.slf4j.Logger;
> nit: move this to line 41. We try to maintain imports in order.
Done



--
To view, visit http://gerrit.cloudera.org:8080/18373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0acd83e8e237ea6a1d5fe1e9e440db0dd68b09c
Gerrit-Change-Number: 18373
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn>
Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Wed, 06 Apr 2022 02:51:12 +0000
Gerrit-HasComments: Yes

Reply via email to